Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources to dep list of Prometheus exporter test #1527

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

ThomsonTan
Copy link
Contributor

Fixes #1526

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team July 28, 2022 17:03
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix :)

@esigo esigo enabled auto-merge (squash) July 28, 2022 17:12
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1527 (bc65bba) into main (e4f3a9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1527   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files         155      155           
  Lines        4782     4782           
=======================================
  Hits         4046     4046           
  Misses        736      736           

@esigo esigo merged commit 0015475 into open-telemetry:main Jul 28, 2022
@ThomsonTan ThomsonTan deleted the FixPromTest branch November 9, 2022 22:56
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake build failed of Prometheus exporter test fails
2 participants