Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics unit test memory leack #1533

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Fix metrics unit test memory leack #1533

merged 1 commit into from
Jul 31, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Jul 31, 2022

Fixes #1532 (issue)

Changes

fixes the leaks by using smart pointer.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team July 31, 2022 08:10
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@9e6fd1e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1533   +/-   ##
=======================================
  Coverage        ?   84.65%           
=======================================
  Files           ?      155           
  Lines           ?     4781           
  Branches        ?        0           
=======================================
  Hits            ?     4047           
  Misses          ?      734           
  Partials        ?        0

lalitb
lalitb approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.

@esigo esigo merged commit d452e8e into open-telemetry:main Jul 31, 2022
@esigo esigo deleted the unit-test-mem-leack branch July 31, 2022 17:48
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@esigo @yxue
Fix metrics unit test memory leack (open-telemetry#1533)
bd35f8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unit test memory leak
2 participants
@esigo @lalitb