Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter support Gauge Type #1553

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Aug 10, 2022

Fixes #1551 (issue)

Changes

Prometheus exporter supports Gauge Type and added error handling.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team August 10, 2022 17:27
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1553 (46213d6) into main (45037ac) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   83.91%   83.93%   +0.03%     
==========================================
  Files         156      156              
  Lines        4908     4908              
==========================================
+ Hits         4118     4119       +1     
+ Misses        790      789       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.41% <0.00%> (+0.79%) ⬆️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@esigo esigo merged commit f0109eb into open-telemetry:main Aug 10, 2022
@esigo esigo deleted the Prometheus-Gauge-Type branch August 10, 2022 19:28
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus exporter does not handle Gauge Type Metric
2 participants