Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics SDK] Fix IWYU error in instruments.h #1555

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

bsarden
Copy link
Contributor

@bsarden bsarden commented Aug 11, 2022

No description provided.

@bsarden bsarden requested a review from a team August 11, 2022 02:14
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1555 (9788d34) into main (f0109eb) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1555      +/-   ##
==========================================
+ Coverage   83.87%   83.93%   +0.07%     
==========================================
  Files         156      156              
  Lines        4908     4908              
==========================================
+ Hits         4116     4119       +3     
+ Misses        792      789       -3     
Impacted Files Coverage Δ
...dk/include/opentelemetry/sdk/metrics/instruments.h 0.00% <ø> (ø)
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. std::function was added recently, header got missed.

@lalitb lalitb merged commit b4ed047 into open-telemetry:main Aug 11, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants