Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gRPC to v1.48.1 for CMake Linux CI #1608

Merged
merged 10 commits into from
Sep 26, 2022
Merged

Conversation

esigo
Copy link
Member

@esigo esigo commented Sep 10, 2022

Fixes #1607 (issue)

Changes

Adds a new CI which tests otlp exporters using the latest gRPC release.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team September 10, 2022 17:31
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #1608 (b2e82b6) into main (5c180a1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1608   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files         159      159           
  Lines        4999     4999           
=======================================
  Hits         4255     4255           
  Misses        744      744           

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb
Copy link
Member

lalitb commented Sep 11, 2022

Thanks for the PR. A couple of nit comments

@ThomsonTan
Copy link
Contributor

Thanks for the PR. A couple of nit comments

  • Instead of adding a new CI, should we use the latest gRPC for all cmake builds on ubuntu-latest/ubuntu-20.04/ubuntu-20.10. These virtual machine uses g++-9.3 as the default compiler, which builds in c++-14 mode.
  • Can we try using the latest gRPC for bazel builds too? Not sure if it will work, as it failed earlier in Upgrade to gRPC 1.46.3 (#1459) #1462. We can do it in separate PR if it takes time
  • Should we document the gRPC dependency here - open-telemetry/opentelemetry-cpp#supported-development-platforms. We already do it for gcc4.8 for gRPC here.

One more item is for Windows build, could we also make the same update there?

@lalitb
Copy link
Member

lalitb commented Sep 12, 2022

One more item is for Windows build, could we also make the same update there?

That can be challenging it seems. We use vcpkg to install windows dependencies as here and latest gRPC version in vcpkg is v1.41.0.

@marcalff marcalff mentioned this pull request Sep 19, 2022
3 tasks
@esigo esigo changed the title add CI test with gRPC latest release bump gRPC to v1.48.1 Sep 24, 2022
@esigo esigo changed the title bump gRPC to v1.48.1 bump gRPC to v1.48.1 for CMake Linux CI Sep 24, 2022
@esigo
Copy link
Member Author

esigo commented Sep 24, 2022

@lalitb Windows CMake CI doesn't use gRPC.
We use C++14 for building gRPC itself only so I believe we don't need to change our documentation. I would keep this PR as it is.

I raised another PR to bump vcpkg #1633. I created another issue for bazel #1634.

@esigo
Copy link
Member Author

esigo commented Sep 25, 2022

meanwhile gRPC 1.49.1 released.

@esigo esigo merged commit 0bd57d6 into open-telemetry:main Sep 26, 2022
@esigo esigo deleted the gRPC-latest branch September 26, 2022 20:20
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI test with C++14, and latest gRPC release.
4 participants