[gRPC]: Fix oob access of string_view in example #1619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GrpcClient/ServerCarrier in the gRPC examples assume that the provided string_views are null-terminated,
which is not necessarily the case, e.g. when they are provided by the HttpTraceContext:
opentelemetry-cpp/api/include/opentelemetry/trace/propagation/http_trace_context.h
Lines 89 to 102 in 82a8115