-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake OTELCPP_MAINTAINER_MODE #1650
Conversation
Add a MAINTAINER_MODE in CMake. Build with gcc and clang in maintainer mode in github CI.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
==========================================
- Coverage 85.82% 85.77% -0.05%
==========================================
Files 169 169
Lines 5133 5134 +1
==========================================
- Hits 4405 4403 -2
- Misses 728 731 +3
|
To @open-telemetry/cpp-approvers This PR adds three new builds in CI:
These new build actually fail, which is the point: find additional warnings in the code. Failure seen by GCC:
Failure seen by CLang:
This PR is ready for review. Once more warnings are reported by the build, subsequent warning cleanups PR can be filed to fix the issues found, like #1649 Note that the new builds are not required to pass, so this will not block any work. |
Moved grpc work around to protobuf_include_prefix.h Disabled some warnings for windows. Also, used windows-latest (2022)
Setting to draft: Using this branch to check existing warnings, Once the main branch is clean, this can be then merged to main. |
Status: As of 2022-10-10, remaining issues count is:
|
so it is not enforced on third party code.
Status: As of 2022-10-12:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
Thanks all for the review. Ready to merge. |
…ad-local-stack * commit '9acde87b08b225ce511fa8a20c6cba14f2921518': (36 commits) Prepare v1.7.0 release with Metrics API/SDK GA. (open-telemetry#1721) Fix: 1712 - Validate Instrument meta data (name, unit, description) (open-telemetry#1713) Document libthrift 0.12.0 doesn't work with Jaeger exporter (open-telemetry#1714) Fix:1674, Add Monotonic Property to Sum Aggregation, and unit tests for Up Down Counter (open-telemetry#1675) [Metrics SDK] Move Metrics Exemplar processing behind feature flag (open-telemetry#1710) [Metrics API/SDK] Change Meter API/SDK to return nostd::unique_ptr for Sync Instruments (open-telemetry#1707) [Metrics] Switch to explicit 64 bit integers (open-telemetry#1686) Add metrics e2e test to asan & tsan CI (open-telemetry#1670) Add otlp-grpc example bazel (open-telemetry#1708) [Metrics SDK] Add support for Pull Metric Reader (open-telemetry#1701) Fix debug log of OTLP HTTP exporter and ES log exporter (open-telemetry#1703) [SEMANTIC CONVENTIONS] Upgrade to version 1.14.0 (open-telemetry#1697) Fix a potential precision loss on integer in ReservoirCellIndexFor (open-telemetry#1696) fix Histogram crash (open-telemetry#1685) Fix:1676 Segfault when short export period is used for metrics (open-telemetry#1682) Add timeout support to MeterContext::ForceFlush (open-telemetry#1673) Add CMake OTELCPP_MAINTAINER_MODE (open-telemetry#1650) [DOCS] - Minor updates to OStream Metrics exporter documentation (open-telemetry#1679) Fix:open-telemetry#1575 API Documentation for Metrics SDK and API (open-telemetry#1678) Fixes open-telemetry#249 (open-telemetry#1677) ...
Fixes #1648
Changes
CMake OTELCPP_MAINTAINER_MODE
Add a new CMake option, OTELCPP_MAINTAINER_MODE.
Option OTELCPP_MAINTAINER_MODE=ON is supported for:
and causes the build to fail on warnings (-Wall -Werror).
This option is useful for maintainers, when testing a build locally.
New CI builds
Add new builds in Github [CI]
These build use OTELCPP_MAINTAINER_MODE=ON,
to enforce the build is warnings free for all compilers.
CHANGELOG.md
updated for non-trivial changes