-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more clang and gcc warnings #1658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some warnings reported by clang. -Wnewline-eof no newline at end of file -Wc++98-compat-extra-semi extra ';' outside of a function is incompatible with C++98 -Winconsistent-missing-destructor-override '~XXX' overrides a destructor but is not marked 'override' -Wheader-hygiene using namespace directive in global context in header -Wunused-parameter unused parameter Fixed some warnings reported by gcc. -Werror=missing-field-initializers missing initializer for member ‘opentelemetry::v1::sdk::trace::SamplingResult::trace_state’ -Werror=unused-variable unused variable -Werror=unused-parameter unused parameter
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
+ Coverage 84.39% 84.41% +0.03%
==========================================
Files 168 170 +2
Lines 5122 5130 +8
==========================================
+ Hits 4322 4330 +8
Misses 800 800
|
owent
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
esigo
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fixes :)
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Fixed some warnings reported by clang. -Wnewline-eof no newline at end of file -Wc++98-compat-extra-semi extra ';' outside of a function is incompatible with C++98 -Winconsistent-missing-destructor-override '~XXX' overrides a destructor but is not marked 'override' -Wheader-hygiene using namespace directive in global context in header -Wunused-parameter unused parameter Fixed some warnings reported by gcc. -Werror=missing-field-initializers missing initializer for member ‘opentelemetry::v1::sdk::trace::SamplingResult::trace_state’ -Werror=unused-variable unused variable -Werror=unused-parameter unused parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1649
Changes
Fixed some warnings reported by clang.
-Wnewline-eof
no newline at end of file
-Wc++98-compat-extra-semi
extra ';' outside of a function is incompatible with C++98
-Winconsistent-missing-destructor-override
'~XXX' overrides a destructor but is not marked 'override'
-Wheader-hygiene
using namespace directive in global context in header
-Wunused-parameter
unused parameter
-Wrange-loop-bind-reference
Fixed some warnings reported by gcc.
-Werror=missing-field-initializers
missing initializer for member ‘opentelemetry::v1::sdk::trace::SamplingResult::trace_state’
-Werror=unused-variable
unused variable
-Werror=unused-parameter
unused parameter
Added override keywords, and fixed casts to use const_cast.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes