-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics SDK] Change Prometheus CMake target name #1765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with format fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fix :)
I think we need to clean cache:
can be done as explained here |
Thanks @esigo . |
Fixes #1764
Changed the target name to
opentelemetry_exporter_prometheus
.$ ls /usr/local/lib/libopentelemetry_* -ltr -rw-r--r-- 1 root root 5884858 Oct 28 08:10 /usr/local/lib/libopentelemetry_proto.a -rw-r--r-- 1 root root 874006 Oct 28 16:19 /usr/local/lib/libopentelemetry_otlp_recordable.a -rw-r--r-- 1 root root 3300 Nov 10 16:11 /usr/local/lib/libopentelemetry_version.a -rw-r--r-- 1 root root 144904 Nov 10 16:11 /usr/local/lib/libopentelemetry_common.a -rw-r--r-- 1 root root 2794826 Nov 10 16:11 /usr/local/lib/libopentelemetry_resources.a -rw-r--r-- 1 root root 1910868 Nov 10 16:11 /usr/local/lib/libopentelemetry_http_client_curl.a -rw-r--r-- 1 root root 5777388 Nov 10 16:11 /usr/local/lib/libopentelemetry_trace.a -rw-r--r-- 1 root root 19873766 Nov 10 16:11 /usr/local/lib/libopentelemetry_metrics.a -rw-r--r-- 1 root root 1559820 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_ostream_metrics.a -rw-r--r-- 1 root root 2175672 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_prometheus.a -rw-r--r-- 1 root root 2887576 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_ostream_span.a -rw-r--r-- 1 root root 2444300 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_in_memory.a -rw-r--r-- 1 root root 411284 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_client.a -rw-r--r-- 1 root root 2518 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_log.a -rw-r--r-- 1 root root 1780364 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http_client.a -rw-r--r-- 1 root root 941658 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http_metric.a -rw-r--r-- 1 root root 1017242 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http.a -rw-r--r-- 1 root root 1021982 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_metrics.a -rw-r--r-- 1 root root 1093522 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc.a -rw-r--r-- 1 root root 4246512 Nov 10 16:29 /usr/local/lib/libopentelemetry_exporter_zipkin_trace.a