-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] OTLP HTTP Exporter has build warnings in maintainer mode #1943
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
=======================================
Coverage 87.12% 87.12%
=======================================
Files 165 165
Lines 4596 4596
=======================================
Hits 4004 4004
Misses 592 592
|
@@ -38,5 +38,5 @@ wget https://github.com/google/protobuf/releases/download/v${PROTOBUF_VERSION}/p | |||
tar zxf protobuf-cpp-${CPP_PROTOBUF_VERSION}.tar.gz --no-same-owner | |||
cd protobuf-${CPP_PROTOBUF_VERSION} | |||
./configure | |||
make -j ${nproc} && make install | |||
make && make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may use make -j || make && make install
to reduce the compiling time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @owent
This part changed a bit back and forth, not sure which commit you looked at.
Currently the code is make -j $(nproc) && make install
When using make -j ${nproc}
, which was wrong because there is no nproc
environment variable, make -j
was executed alone ... this killed the github CI.
make -j $(nproc)
, which is used in different places already, correctly invokes the nproc utility to return the number of cores. This works fine in CI now.
So, parallel make is used already, precisely to reduce the compiling time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation.LGTM now.
Fixes #1942
Changes
Fixed build warnings in the OTLP HTTP exporter.
Added OTLP HTTP to the
MAINTAINER_MODE
CI.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes