Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade Google Benchmark version from 1.6.0 to 1.7.1 #2116

Merged

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Apr 23, 2023

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2116 (d613967) into main (a39e8b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2116   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         166      166           
  Lines        4784     4784           
=======================================
  Hits         4171     4171           
  Misses        613      613           

@cngzhnp cngzhnp marked this pull request as ready for review April 23, 2023 21:07
@cngzhnp cngzhnp requested a review from a team April 23, 2023 21:07
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the third_party_release too.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@cngzhnp cngzhnp force-pushed the feature/update_google_benchmark_version branch from cda9bc9 to 3ed3243 Compare April 24, 2023 10:03
@cngzhnp
Copy link
Contributor Author

cngzhnp commented Apr 24, 2023

I realized that ci/ports/benchmark folder needs to be updated as well due to this change, @lalitb @marcalff. Could you please check it again?

@lalitb
Copy link
Member

lalitb commented Apr 25, 2023

I realized that ci/ports/benchmark folder needs to be updated as well due to this change,

ci/ports/benchmark is special backport for old compilers, I think we can leave it. However for windows, we should sometime update the vcpkg submodule (as done in #1633), this can be handled as separate PR.

@lalitb lalitb enabled auto-merge (squash) April 27, 2023 05:19
@lalitb lalitb merged commit 6c7f7c8 into open-telemetry:main Apr 27, 2023
@marcalff marcalff changed the title Upgrade Google Benchmark version from 1.6.0 to 1.7.1 [CI] Upgrade Google Benchmark version from 1.6.0 to 1.7.1 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants