Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade abseil-cpp version from 20220623.1 to 20230125.2 #2117

Closed

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Apr 23, 2023

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@cngzhnp cngzhnp force-pushed the feature/update_abseil_cpp_version branch from 2ea0355 to 6b3a920 Compare April 23, 2023 21:11
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2117 (39597d5) into main (a39e8b5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2117   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         166      166           
  Lines        4784     4784           
=======================================
  Hits         4171     4171           
  Misses        613      613           

@cngzhnp cngzhnp force-pushed the feature/update_abseil_cpp_version branch from 6b3a920 to 2c12c36 Compare April 23, 2023 21:16
@cngzhnp cngzhnp force-pushed the feature/update_abseil_cpp_version branch from 2c12c36 to 39597d5 Compare April 23, 2023 21:24
@marcalff
Copy link
Member

@cngzhnp

Thanks for the PR.

The upgrade of abseil itself looks ok.

This PR needs some coordination with the deprecation of C++11 (PR and date to be announced), to make sure the transition to C++14 and upgrade of dependencies are clean.

@marcalff marcalff added this to the Migrate to C++14 milestone May 23, 2023
@marcalff marcalff changed the title Upgrade abseil-cpp version from 20220623.1 to 20230125.2 [CI] Upgrade abseil-cpp version from 20220623.1 to 20230125.2 May 26, 2023
@CoderPoet
Copy link

If this PR is not merged, will there be incompatibilities when opentelemetry-cpp is used with the new version of absl?

@CoderPoet
Copy link

If this PR is not merged, will there be incompatibilities when opentelemetry-cpp is used with the new version of absl?

An issue with version conflicts was encountered:#2238

@marcalff
Copy link
Member

This PR is no longer needed, as PR #2163 already upgraded abseil-cpp to version 20230125.3

Closing.

@marcalff marcalff closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants