Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Do not tag pull_request with the "needs-triage" label. #2228

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[CI] Do not tag pull_request with the "needs-triage" label. #2228

merged 1 commit into from
Jul 11, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jul 11, 2023 •
edited
Loading

Changes

[CI] Do not tag pull_request with the "needs-triage" label.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team July 11, 2023 08:43
@marcalff
Copy link
Member Author

Please review.

This is required to make CI pass (it is currently broken for new PR).

Also, I don't think we need triage labels on PR themselves when submitted, this can be simplified.

@marcalff marcalff added priority:p0 Issues which require immediate action to stop bleeding issue:blocking This issue is preventing other fixes labels Jul 11, 2023
@marcalff marcalff changed the title [CI] Do not tag pull_request with the "need-triage" label. [CI] Do not tag pull_request with the "needs-triage" label. Jul 11, 2023
@marcalff marcalff merged commit f5426ce into open-telemetry:main Jul 11, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 14, 2023
Merged
@marcalff marcalff deleted the fix_pr_workflow branch September 5, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
issue:blocking This issue is preventing other fixes priority:p0 Issues which require immediate action to stop bleeding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcalff @lalitb