-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Cardinality limits for metrics streams (Sync Instruments + Delta Temporality) #2255
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
==========================================
+ Coverage 87.43% 87.43% +0.01%
==========================================
Files 199 199
Lines 6028 6052 +24
==========================================
+ Hits 5270 5291 +21
- Misses 758 761 +3
|
This is ready for review now. |
sdk/include/opentelemetry/sdk/metrics/state/attributes_hashmap.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/metrics/state/attributes_hashmap.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early review comments.
sdk/include/opentelemetry/sdk/metrics/state/attributes_hashmap.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overflow value
Thanks for the comments @marcalff. They are valid, have fixed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks :)
Changes
#2347
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes