-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Use fully qualified references to trace/common namespace #2424
Conversation
f711291
to
4a352b6
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@ThomsonTan unfortunately on my mac format produces crazy results (maybe some hints on how to properly run would be appreciated), is it possible to help me with formatting this code? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2424 +/- ##
==========================================
- Coverage 87.06% 87.04% -0.01%
==========================================
Files 199 199
Lines 6079 6080 +1
==========================================
Hits 5292 5292
- Misses 787 788 +1
|
@bogdandrutu - You can do this by
|
@bogdandrutu you could use docker: ./ci/run_docker.sh tools/format.sh |
@esigo that is awesome, but not documented :) Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the format been fixed.
Applied clang-format-10 and pushed to your branch. |
Fixes #2417