Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMANTIC CONVENTIONS] Code generation script fails on SELINUX #2455

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

marcalff
Copy link
Member

Fixes #2454

Changes

In SELINUX, mount docker volumes with the :z option, to share files with the parent.

Tested with podman, with SELINUX Enforcing

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team December 14, 2023 21:34
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #2455 (2b91cfc) into main (ab440e4) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2455   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6087     6087           
=======================================
  Hits         5299     5299           
  Misses        788      788           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@ThomsonTan ThomsonTan merged commit ebb45c6 into open-telemetry:main Dec 15, 2023
46 checks passed
@marcalff marcalff deleted the fix_selinux_2454 branch June 3, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SEMANTIC CONVENTIONS] Code generation script fails on SELINUX
3 participants