-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REMOVAL] Remove build option WITH_DEPRECATED_SDK_FACTORY
#2717
[REMOVAL] Remove build option WITH_DEPRECATED_SDK_FACTORY
#2717
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2717 +/- ##
==========================================
+ Coverage 87.12% 87.66% +0.55%
==========================================
Files 200 190 -10
Lines 6109 5858 -251
==========================================
- Hits 5322 5135 -187
+ Misses 787 723 -64
|
Please review. I suggest to wait at one or two weeks for possible comments on this (the removal issue is pinned), before merging to main. |
Should this PR be included in the coming minor build (like 1.7.0) instead of patch build? |
Current release is 1.16.0, so next patch build will be 1.16.1 This removal should only be part of release 1.17.0, and not part of the 1.16.1 patch, I agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one note is to merging this after the patch release of 1.6.1.
Fixes #2716
Changes
Please provide a brief description of the changes here.
WITH_DEPRECATED_SDK_FACTORY
WITH_OTLP
WITH_LOGS_PREVIEW
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes