-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] ForceFlush before canceling the running requests on shutdown. #2727
Merged
marcalff
merged 7 commits into
open-telemetry:main
from
owent:fixes_shutdown_in_otlp_exporter
Jul 19, 2024
Merged
[EXPORTER] ForceFlush before canceling the running requests on shutdown. #2727
marcalff
merged 7 commits into
open-telemetry:main
from
owent:fixes_shutdown_in_otlp_exporter
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
==========================================
+ Coverage 87.12% 87.66% +0.55%
==========================================
Files 200 190 -10
Lines 6109 5858 -251
==========================================
- Hits 5322 5135 -187
+ Misses 787 723 -64 |
owent
force-pushed
the
fixes_shutdown_in_otlp_exporter
branch
from
July 1, 2024 07:25
44adc77
to
0b29cc3
Compare
marcalff
changed the title
[WIP]ForceFlush before cancling the running requests when shutdown.
[WIP] ForceFlush before canceling the running requests on shutdown.
Jul 4, 2024
owent
changed the title
[WIP] ForceFlush before canceling the running requests on shutdown.
ForceFlush before canceling the running requests on shutdown.
Jul 7, 2024
marcalff
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
marcalff
changed the title
ForceFlush before canceling the running requests on shutdown.
[EXPORTER] ForceFlush before canceling the running requests on shutdown.
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2715
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes