Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Add a CMake option to disable shared libs #3095

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Oct 12, 2024

This option is useful to support platforms that do not support dynamic libraries and dlopen.

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

This option is useful to support platforms that do not support
dynamic libraries and `dlopen`.
@tobim tobim requested a review from a team as a code owner October 12, 2024 12:23
Copy link

linux-foundation-easycla bot commented Oct 12, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 569b2da
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6716bd1fa07ea400084683b0

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (497eaf4) to head (569b2da).
Report is 145 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
+ Coverage   87.12%   87.91%   +0.79%     
==========================================
  Files         200      195       -5     
  Lines        6109     6133      +24     
==========================================
+ Hits         5322     5391      +69     
+ Misses        787      742      -45     

see 98 files with indirect coverage changes

@owent
Copy link
Member

owent commented Oct 14, 2024

Is this PR not finished yet? All add_library calls should consider this new option?

@tobim
Copy link
Contributor Author

tobim commented Oct 14, 2024

It is finished. The option only makes sense to use without -DBUILD_SHARED_LIBS=ON. Sorry for not making that clear.

CMakeLists.txt Outdated Show resolved Hide resolved
@marcalff marcalff changed the title Add a CMake option to disable shared libs [BUILD] Add a CMake option to disable shared libs Oct 16, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 7402ed9 into open-telemetry:main Oct 21, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants