-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Fix compiling problems for gcc 4.8 #3100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3100 +/- ##
==========================================
+ Coverage 87.12% 87.81% +0.69%
==========================================
Files 200 195 -5
Lines 6109 5969 -140
==========================================
- Hits 5322 5241 -81
+ Misses 787 728 -59
|
marcalff
changed the title
Fix compiling problems for gcc 4.8
[BUILD] Fix compiling problems for gcc 4.8
Oct 16, 2024
marcalff
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ThomsonTan
reviewed
Oct 16, 2024
marcalff
reviewed
Oct 17, 2024
marcalff
reviewed
Oct 17, 2024
marcalff
approved these changes
Oct 17, 2024
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Oct 17, 2024
[BUILD] Fix compiling problems for gcc 4.8 (open-telemetry#3100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3099
Changes
Fix remaining issues preventing a C++11 build with gcc 4.8.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes