Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix compiling problems for gcc 4.8 #3100

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

owent
Copy link
Member

@owent owent commented Oct 16, 2024

Fixes #3099

Changes

Fix remaining issues preventing a C++11 build with gcc 4.8.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner October 16, 2024 10:28
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit d4531be
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6710b749c8daaa00085e65d8

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (497eaf4) to head (d4531be).
Report is 142 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3100      +/-   ##
==========================================
+ Coverage   87.12%   87.81%   +0.69%     
==========================================
  Files         200      195       -5     
  Lines        6109     5969     -140     
==========================================
- Hits         5322     5241      -81     
+ Misses        787      728      -59     
Files with missing lines Coverage Δ
exporters/memory/src/in_memory_metric_data.cc 85.00% <100.00%> (ø)
...rs/memory/src/in_memory_metric_exporter_factory.cc 100.00% <100.00%> (ø)

... and 125 files with indirect coverage changes

@marcalff marcalff changed the title Fix compiling problems for gcc 4.8 [BUILD] Fix compiling problems for gcc 4.8 Oct 16, 2024
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcalff marcalff merged commit 63683c1 into open-telemetry:main Oct 17, 2024
56 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Oct 17, 2024
[BUILD] Fix compiling problems for gcc 4.8 (open-telemetry#3100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not compile when using WITH_STL=CXX11 with legacy toolchain
4 participants