Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Comment the arm64 CI #3125

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 6, 2024

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

Comment out CI for arm64, due to the lack of runners.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 6d7bfd0
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/672ab28b3eacbe0008fbb4a0

@marcalff marcalff marked this pull request as ready for review November 6, 2024 00:05
@marcalff marcalff requested a review from a team as a code owner November 6, 2024 00:05
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (497eaf4) to head (6d7bfd0).
Report is 153 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
+ Coverage   87.12%   87.88%   +0.76%     
==========================================
  Files         200      195       -5     
  Lines        6109     6137      +28     
==========================================
+ Hits         5322     5393      +71     
+ Misses        787      744      -43     

see 99 files with indirect coverage changes

# Commented 2024-11-06, lack of workers in github causes CI failures
# arm64_test:
# name: CMake test arm64 (with modern protobuf,grpc and abseil)
# runs-on: actuated-arm64-4cpu-16gb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted.

A separate PR is better, so we can unlock the builds and get CI flowing again now.

@marcalff marcalff merged commit 6fdf797 into open-telemetry:main Nov 6, 2024
55 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants