-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER]: Elasticsearch exporter put log resource in root instead of under 'resources' #3131
[EXPORTER]: Elasticsearch exporter put log resource in root instead of under 'resources' #3131
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
==========================================
+ Coverage 87.12% 87.85% +0.73%
==========================================
Files 200 195 -5
Lines 6109 6136 +27
==========================================
+ Hits 5322 5390 +68
+ Misses 787 746 -41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/es_log_recordable.h
Show resolved
Hide resolved
84ba218
to
d752666
Compare
In the CHANGELOG.md, please add an entry for important changes, to document that resources are no longer added under "root/resource" but are added under root instead. I will merge this PR after that. Thanks for the fix. |
under 'resources' Closes open-telemetry#3119
d752666
to
1a0d85e
Compare
@marcalff done |
Thanks. I meant a section similar to this:
but since there is a note in the changelog, I will notice it and edit it when doing the next release, so this will do for now. Merging. |
In order to give the user full flexibility on what and where to put resources for logs, remove the fact that it was forced to always be under the
resource
.This allows to have resources such as
client.id
that will be under the root and compliant with ECS format.Closes #3119
Changes
Log resources are set under the root object and not under
resources
anymore.