Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add tracer scope configurator #3137

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Nov 12, 2024

Re #2641

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 2c55339
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6738ebd51ef44f000879aebd

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.81%. Comparing base (a388e87) to head (2c55339).

Files with missing lines Patch % Lines
sdk/src/trace/tracer_provider_factory.cc 50.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3137      +/-   ##
==========================================
- Coverage   87.83%   87.81%   -0.02%     
==========================================
  Files         195      197       +2     
  Lines        6146     6176      +30     
==========================================
+ Hits         5398     5423      +25     
- Misses        748      753       +5     
Files with missing lines Coverage Δ
...y/sdk/instrumentationscope/instrumentation_scope.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/trace/tracer.h 100.00% <ø> (ø)
...dk/include/opentelemetry/sdk/trace/tracer_config.h 100.00% <100.00%> (ø)
...k/include/opentelemetry/sdk/trace/tracer_context.h 100.00% <ø> (ø)
sdk/src/trace/tracer.cc 83.34% <100.00%> (+0.88%) ⬆️
sdk/src/trace/tracer_config.cc 100.00% <100.00%> (ø)
sdk/src/trace/tracer_context.cc 84.00% <100.00%> (+2.19%) ⬆️
sdk/src/trace/tracer_provider.cc 89.14% <100.00%> (ø)
sdk/src/trace/tracer_provider_factory.cc 46.16% <50.00%> (+1.33%) ⬆️

@psx95 psx95 force-pushed the add-scope-config branch 2 times, most recently from fee7f7c to 15274c0 Compare November 15, 2024 00:09
@psx95 psx95 force-pushed the add-scope-config branch 2 times, most recently from dd70641 to 0370722 Compare November 16, 2024 17:26
@psx95 psx95 changed the title Add scope config [WIP] Add scope config Nov 16, 2024
@psx95 psx95 changed the title [WIP] Add scope config [WIP] Add tracer scope configurator Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant