Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIM] Fix string_view mappings between OT and OTel #3181

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

chusitoo
Copy link
Contributor

@chusitoo chusitoo commented Dec 2, 2024

Fixes #3180

Changes

All the conversions opentracing::string_view to nostd::string_view or backwards take the size as second argument.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit b445e2e
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/674db92cdac14100082f4935

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (fb6fde8) to head (b445e2e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3181   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         195      195           
  Lines        6151     6151           
=======================================
  Hits         5404     5404           
  Misses        747      747           

@chusitoo chusitoo marked this pull request as ready for review December 2, 2024 14:17
@chusitoo chusitoo requested a review from a team as a code owner December 2, 2024 14:17
@marcalff marcalff merged commit f167c36 into open-telemetry:main Dec 2, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SHIM] Dangerous use of string_view
3 participants