Add -recursive to recommended git clone command line #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 94.54% 94.59% +0.05%
==========================================
Files 179 179
Lines 7677 7677
==========================================
+ Hits 7258 7262 +4
+ Misses 419 415 -4
|
lalitb
reviewed
Dec 4, 2020
lalitb
approved these changes
Dec 4, 2020
|
Triaged Dec 7 2020: @jsuereth can you please review so that this can be merged? |
pyohannes
approved these changes
Dec 8, 2020
jsuereth
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-resursiveis available an option for git since 1.6.5 which clones all submodules. The current version of git is 2.28 or above so I think it is fine to expect-recursivefor git. This would be very helpful as we added many dependencies as submodule to this repo.Also add line-ending setting for
.ccfile which is missing.