Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly initialize the curl::Session when a schema is given #476

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Correctly initialize the curl::Session when a schema is given #476

merged 4 commits into from
Dec 22, 2020

Conversation

pyohannes
Copy link
Contributor

The initialization of a curl::Session did not work for cases where a scheme was given with the host name.

This PR adds a fix and tests.

@pyohannes pyohannes requested a review from a team December 21, 2020 23:14
@codecov
Copy link

codecov bot commented Dec 21, 2020 •
edited
Loading

Codecov Report

Merging #476 (5002978) into master (1e7b9d8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   94.43%   94.43%   -0.01%     
==========================================
  Files         187      187              
  Lines        8233     8244      +11     
==========================================
+ Hits         7775     7785      +10     
- Misses        458      459       +1
Impacted Files Coverage Δ
...ntelemetry/ext/http/client/curl/http_client_curl.h 95.12% <100.00%> (+0.12%) ⬆️
ext/test/http/curl_http_test.cc 93.90% <100.00%> (+0.35%) ⬆️
sdk/test/metrics/counter_aggregator_test.cc 98.21% <0.00%> (-1.79%) ⬇️
sdk/test/common/circular_buffer_test.cc 98.97% <0.00%> (-1.03%) ⬇️
sdk/test/metrics/exact_aggregator_test.cc 100.00% <0.00%> (+0.90%) ⬆️

@pyohannes pyohannes added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Dec 22, 2020
lalitb
lalitb approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.

@lalitb lalitb merged commit 9039454 into open-telemetry:master Dec 22, 2020
kxyr pushed a commit to open-o11y/opentelemetry-cpp that referenced this pull request Dec 22, 2020
@pyohannes
Correctly initialize the curl::Session when a schema is given (open-t…
20597ed 
…elemetry#476)
kxyr pushed a commit to open-o11y/opentelemetry-cpp that referenced this pull request Dec 22, 2020
@pyohannes
Correctly initialize the curl::Session when a schema is given (open-t…
e91c372 
…elemetry#476)
@pyohannes pyohannes linked an issue Dec 22, 2020 that may be closed by this pull request
W3C TraceContext compliance #74
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

W3C TraceContext compliance
3 participants
@pyohannes @ThomsonTan @lalitb