Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate TraceState with http_trace_context propagator #563

Merged
merged 7 commits into from
Mar 4, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Feb 5, 2021

Adding tracestate header support for w3c tracecontext.
Fixes #507

@lalitb lalitb changed the title [Draft] Integrate TraceState with http_trace_context propagator [Not For Review] Integrate TraceState with http_trace_context propagator Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #563 (ef0d0b5) into main (89cb684) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   94.33%   94.35%   +0.02%     
==========================================
  Files         189      189              
  Lines        8949     8964      +15     
==========================================
+ Hits         8442     8458      +16     
+ Misses        507      506       -1     
Impacted Files Coverage Δ
...entelemetry/trace/propagation/http_trace_context.h 86.66% <100.00%> (+0.25%) ⬆️
...pi/test/trace/propagation/http_text_format_test.cc 100.00% <100.00%> (+1.69%) ⬆️
...include/opentelemetry/sdk/common/circular_buffer.h 97.87% <0.00%> (-2.13%) ⬇️
sdk/src/logs/batch_log_processor.cc 95.00% <0.00%> (+1.25%) ⬆️

@lalitb lalitb marked this pull request as ready for review February 26, 2021 08:55
@lalitb lalitb requested a review from a team February 26, 2021 08:55
@lalitb
Copy link
Member Author

lalitb commented Feb 26, 2021

@open-telemetry/cpp-approvers this is now moved out of draft, and ready for review. thanks.

@lalitb lalitb changed the title [Not For Review] Integrate TraceState with http_trace_context propagator Integrate TraceState with http_trace_context propagator Feb 26, 2021
@lalitb lalitb merged commit b8a08eb into open-telemetry:main Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TraceContext propagation: Adding support for tracestate header
2 participants