Add TraceState in SamplerResult, and use it for creating span context. #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
lalitb
changed the title
Codecov Report
@@ Coverage Diff @@
## main #591 +/- ##
==========================================
+ Coverage 94.39% 94.41% +0.01%
==========================================
Files 191 191
Lines 9053 9066 +13
==========================================
+ Hits 8546 8560 +14
+ Misses 507 506 -1
|
ThomsonTan
approved these changes
Mar 10, 2021
sdk/src/trace/span.h
Outdated
| @@ -22,7 +22,9 @@ class Span final : public trace_api::Span | |||
| const trace_api::SpanContextKeyValueIterable &links, | |||
| const trace_api::StartSpanOptions &options, | |||
| const trace_api::SpanContext &parent_span_context, | |||
| const opentelemetry::sdk::resource::Resource &resource) noexcept; | |||
| const opentelemetry::sdk::resource::Resource &resource, | |||
| const nostd::shared_ptr<opentelemetry::trace::TraceState> trace_state = | |||
There was a problem hiding this comment.
FYI, this might be conflicted with the trace_flags change which needs to be resolved.
pyohannes
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556
Changes
Changes includes
sdk::spanconstructor to be used for creating current span context.sdk::spanFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes