Add Jaeger propagator #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 94.40% 94.45% +0.04%
==========================================
Files 191 197 +6
Lines 9066 9183 +117
==========================================
+ Hits 8559 8674 +115
- Misses 507 509 +2
|
lalitb
approved these changes
Mar 8, 2021
| @@ -93,6 +93,17 @@ class Context | |||
|
|
|||
| bool operator==(const Context &other) const noexcept { return (head_ == other.head_); } | |||
|
|
|||
| trace::SpanContext GetCurrentSpan() const | |||
There was a problem hiding this comment.
Nit: Ideally Context class should be agnostic of what is stored inside. Do you think we can instead keep it under propagation::detail namespace ?
There was a problem hiding this comment.
Moved it to propagation::detail, but I think the context API is somewhat unfriendly to users, especially if accessing and setting spans is probably the most common use case.
ThomsonTan
reviewed
Mar 11, 2021
| } | ||
|
|
||
| nostd::string_view trace_id_hex = trace_fields[0]; | ||
| nostd::string_view span_id_hex = trace_fields[1]; |
There was a problem hiding this comment.
Is trace_fields[2] not used?
There was a problem hiding this comment.
Yup, it's the deprecated parent span ID (https://www.jaegertracing.io/docs/1.22/client-libraries/#value)
ThomsonTan
approved these changes
Mar 12, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542
Changes
Adds Jaeger trace extraction and injection as specified here.
Baggage is not part of the PR as it's not supported by the otel-cpp API yet.
Miscellaneous:
GetCurrentSpanduplication from each propagator. Moved it to context's member function.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes