Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Zpages webserver hosting from Exporter #626

Merged
merged 4 commits into from
Mar 30, 2021

Conversation

jsuereth
Copy link
Contributor

  • Creates new shared_ptr thread-safe storage of spans between z-pages http server/aggregation and OTel's SDK.
  • Update ZPages utilities to allow spinning up multiple span processors and attaching them to multiple tracer providers
  • Update ZPages utilties so the server can be instantiated without overwriting the global tracer provider.

@jsuereth jsuereth requested review from maxgolov and a team March 24, 2021 21:17
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #626 (abf0641) into main (179a7f4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   94.49%   94.52%   +0.02%     
==========================================
  Files         197      199       +2     
  Lines        9127     9136       +9     
==========================================
+ Hits         8625     8636      +11     
+ Misses        502      500       -2     
Impacted Files Coverage Δ
...nclude/opentelemetry/ext/zpages/tracez_processor.h 100.00% <100.00%> (ø)
...lude/opentelemetry/ext/zpages/tracez_shared_data.h 100.00% <100.00%> (ø)
ext/src/zpages/tracez_data_aggregator.cc 100.00% <100.00%> (ø)
ext/src/zpages/tracez_processor.cc 100.00% <100.00%> (+4.76%) ⬆️
ext/src/zpages/tracez_shared_data.cc 100.00% <100.00%> (ø)
ext/test/zpages/tracez_data_aggregator_test.cc 96.35% <100.00%> (+0.01%) ⬆️
ext/test/zpages/tracez_processor_test.cc 98.70% <100.00%> (+<0.01%) ⬆️
sdk/src/logs/batch_log_processor.cc 95.00% <0.00%> (+1.25%) ⬆️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Nicely done :)

@lalitb lalitb merged commit 59915e3 into open-telemetry:main Mar 30, 2021
@jsuereth jsuereth deleted the wip-zpages-split branch March 30, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants