Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings of protobuf #645

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

owent
Copy link
Member

@owent owent commented Apr 2, 2021

Related to #249

Changes

Remove warnings of protobuf. There is no functional change.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team April 2, 2021 12:58
@owent owent force-pushed the remove_warnings_from_protobuf branch from 66ff827 to f62a01a Compare April 2, 2021 13:01
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #645 (4f301fe) into main (1a5737a) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   94.65%   94.66%   +0.01%     
==========================================
  Files         203      203              
  Lines        9322     9322              
==========================================
+ Hits         8824     8825       +1     
+ Misses        498      497       -1     
Impacted Files Coverage Δ
sdk/src/logs/batch_log_processor.cc 95.00% <0.00%> (+1.25%) ⬆️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@maxgolov
Copy link
Contributor

maxgolov commented Apr 6, 2021

Thank you!

@lalitb
Copy link
Member

lalitb commented Apr 6, 2021

@owt5008137 Can you rebase the branch with main, that will allow us to merge the changes.

@owent owent force-pushed the remove_warnings_from_protobuf branch from 4503c9f to 4ceb351 Compare April 6, 2021 04:43
@owent
Copy link
Member Author

owent commented Apr 6, 2021

@owt5008137 Can you rebase the branch with main, that will allow us to merge the changes.

@lalitb done.

@lalitb
Copy link
Member

lalitb commented Apr 6, 2021

Not sure why the CLA verification is stuck for this PR, while it is passing for others.

@owent
Copy link
Member Author

owent commented Apr 7, 2021

Not sure why the CLA verification is stuck for this PR, while it is passing for others.

Don't know the reason either, but it seems passed after I click the Update button.

@lalitb lalitb merged commit 85d306f into open-telemetry:main Apr 7, 2021
@owent owent deleted the remove_warnings_from_protobuf branch April 8, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants