-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Custom span-id and trace-id generator #681
Conversation
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
==========================================
+ Coverage 94.64% 94.67% +0.02%
==========================================
Files 206 208 +2
Lines 9382 9407 +25
==========================================
+ Hits 8880 8906 +26
+ Misses 502 501 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great to land, some minor nitpicks,
Minor question about constness
/** | ||
* A Mock Custom Id Generator | ||
*/ | ||
class MockIdGenerator : public IdGenerator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Google Mock would be great to use here, I noticed we don't have it in the repo but EXPECT_CALL and return values can all be done in the test body which would be nice
Co-authored-by: Tom Tan <lilotom@gmail.com>
…y-cpp into custom-id-generation
…y-cpp into custom-id-generation
Fixes #677
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes