Get rid of obsolete core namespace in API #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyohannes
force-pushed
the
remove-core-ns
branch
from
40cb377
to
43588e8
Compare
ThomsonTan
reviewed
Apr 21, 2021
| @@ -27,7 +27,7 @@ class SpanDataEvent | |||
| { | |||
| public: | |||
| SpanDataEvent(std::string name, | |||
| core::SystemTimestamp timestamp, | |||
| opentelemetry::common::SystemTimestamp timestamp, | |||
There was a problem hiding this comment.
Define namespace alias to simplify the namespace reference?
ThomsonTan
approved these changes
Apr 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 210 210
Lines 9644 9647 +3
=======================================
+ Hits 9139 9142 +3
Misses 505 505
|
lalitb
approved these changes
Apr 21, 2021
pyohannes
added
the
pr:please-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The API has a
opentelemetry::corenamespace, which currently contains the classesSystemTimestampandSteadyTimestamp. I see no reason for having separateopentelemetry::coreandopentelemetry::commonnamespace, and I think it would be easier to just have one namespace for components that are shared for multiple OpenTelemetry signals.This PR simplifies the API namespaces layout by removing the
opentelemetry::corenamespace and moving its items toopentelemetry::common.CHANGELOG.mdupdated for non-trivial changes