Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from MPark variant to absl::variant as default #771

Merged
merged 59 commits into from
Jun 4, 2021
Merged

Switch from MPark variant to absl::variant as default #771

merged 59 commits into from
Jun 4, 2021

Commits on May 11, 2021

  1. Add curl via vcpkg to WIndows builds

    @maxgolov
    maxgolov committed May 11, 2021
    Configuration menu
    Copy the full SHA
    076effa View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Merge branch 'main' of http://github.com/open-telemetry/opentelemetry… 

    …-cpp
    @maxgolov
    maxgolov committed May 13, 2021
    Configuration menu
    Copy the full SHA
    0f13e20 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Merge branch 'main' of http://github.com/open-telemetry/opentelemetry… 

    …-cpp
    @maxgolov
    maxgolov committed May 19, 2021
    Configuration menu
    Copy the full SHA
    0540d32 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Merge branch 'main' of http://github.com/open-telemetry/opentelemetry… 

    …-cpp
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    c437cef View commit details
    Browse the repository at this point in the history

  2. Attempt to gracefully switch over from MPark variant to absl::variant

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    54903e8 View commit details
    Browse the repository at this point in the history

  3. Fixing markdownlint warning (sigh)

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    5c7c70c View commit details
    Browse the repository at this point in the history

  4. Add CHANGELOG.md entry about variant implementation switch

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    24ff212 View commit details
    Browse the repository at this point in the history

  5. Fix static vs extern issue in Abseil. Add Abseil Variant to include d… 

    …irectory path.
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    8ed8943 View commit details
    Browse the repository at this point in the history

  6. Isolate to local abseil paths to avoid picking up external Abseil lib… 

    …rary
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    645136f View commit details
    Browse the repository at this point in the history

  7. No need to specify include path to nostd since now local Abseil would… 

    … lookup itself using relative paths
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    8a0b7f4 View commit details
    Browse the repository at this point in the history

  8. HAVE_ABSEIL_VARIANT option is gone because by default we know build A… 

    …PI with Abseil Variant, but without entire Abseil Library
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    bdb22c6 View commit details
    Browse the repository at this point in the history

  9. Issue with GMOCK on Windows

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    dfae1ba View commit details
    Browse the repository at this point in the history

  10. Reinstate the magic of C-string (both std and abseil variant want thi… 

    …s explicitly be defined, no implicit conversion to string_view)
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    963ccf1 View commit details
    Browse the repository at this point in the history

  11. Fix Zipkin exporter to support const char * AttributeValue

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    fd5e041 View commit details
    Browse the repository at this point in the history

  12. Make sure that our local snapshot of Abseil Variant on API surface do… 

    …es not clash with gRPC Abseil
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    e235db2 View commit details
    Browse the repository at this point in the history

  13. attribute_utils.h had wrong order for the enum and missing initialize… 

    …r from std::string
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    41293fd View commit details
    Browse the repository at this point in the history

  14. Adjust Resource to store const char * as std::string

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    4accbbe View commit details
    Browse the repository at this point in the history

  15. Fix build warning that turns an error in Bazel build

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    63f0b63 View commit details
    Browse the repository at this point in the history

  16. Fix for Bazel error with no-exceptions build

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    8047102 View commit details
    Browse the repository at this point in the history

  17. Fix Bazel tsan build

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    206c63c View commit details
    Browse the repository at this point in the history

  18. Can't declare a class using exceptions in a build with no-exceptions

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    4f0910e View commit details
    Browse the repository at this point in the history

  19. Add full set of features to nostd::variant

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    e9e2e85 View commit details
    Browse the repository at this point in the history

  20. Variant test SHOULD NOT make assumptions about how compilers work, wh… 

    …en both `std::` and `absl::` work differently!
    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    a8dfb7d View commit details
    Browse the repository at this point in the history

  21. Re-enable Variant Test that was disabled in CMake build for some reason

    @maxgolov
    maxgolov committed May 20, 2021
    Configuration menu
    Copy the full SHA
    9785f16 View commit details
    Browse the repository at this point in the history

  22. Merge branch 'main' into maxgolov/absl_variant_default

    @maxgolov
    maxgolov authored May 20, 2021
    Configuration menu
    Copy the full SHA
    e389f66 View commit details
    Browse the repository at this point in the history

  23. Merge branch 'main' into maxgolov/absl_variant_default

    @maxgolov
    maxgolov authored May 20, 2021
    Configuration menu
    Copy the full SHA
    ab34030 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Merge branch 'main' of http://github.com/open-telemetry/opentelemetry… 

    …-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed May 21, 2021
    Configuration menu
    Copy the full SHA
    8811b13 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2021

  1. Can't use GSL if it's not found

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    2abdc1a View commit details
    Browse the repository at this point in the history

  2. Add those definitions back globally since we are still building proje… 

    …cts that do not link to opentelemetry_api target
    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    1ea289f View commit details
    Browse the repository at this point in the history

  3. Clan on Mac requires this to be inline

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9d8754d View commit details
    Browse the repository at this point in the history

  4. Add missing classes to STDLIB build

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    a6c41bd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'maxgolov/absl_variant_default' of http://github.com/ope… 

    …n-telemetry/opentelemetry-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    4d10b28 View commit details
    Browse the repository at this point in the history

  6. Code formatting

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    12231f6 View commit details
    Browse the repository at this point in the history

  7. Add proper dependency on json.hpp

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    8037c8a View commit details
    Browse the repository at this point in the history

  8. Fix an issue with not finding json.hpp

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    8e2a481 View commit details
    Browse the repository at this point in the history

  9. Add overload with attributes as initializer list + options, no links

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    c9b56d5 View commit details
    Browse the repository at this point in the history

  10. Make finding json.hpp quiet

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    2dc6cce View commit details
    Browse the repository at this point in the history

  11. Minor formatting

    @maxgolov
    maxgolov committed May 22, 2021
    Configuration menu
    Copy the full SHA
    1d487fd View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Update server.cc 

    Resolve an issue with implicit variant conversion
    @maxgolov
    maxgolov committed May 24, 2021
    Configuration menu
    Copy the full SHA
    ec6b88d View commit details
    Browse the repository at this point in the history

  2. Code formatting

    @maxgolov
    maxgolov committed May 24, 2021
    Configuration menu
    Copy the full SHA
    c067783 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into maxgolov/absl_variant_default

    @maxgolov
    maxgolov authored May 24, 2021
    Configuration menu
    Copy the full SHA
    b1f127d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of http://github.com/open-telemetry/opentelemetry… 

    …-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed May 24, 2021
    Configuration menu
    Copy the full SHA
    8044d02 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'maxgolov/absl_variant_default' of http://github.com/ope… 

    …n-telemetry/opentelemetry-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f3020a5 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Merge branch 'main' into maxgolov/absl_variant_default

    @maxgolov
    maxgolov authored May 25, 2021
    Configuration menu
    Copy the full SHA
    fb5393b View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Merge branch 'main' of http://github.com/open-telemetry/opentelemetry… 

    …-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed May 28, 2021
    Configuration menu
    Copy the full SHA
    8c95419 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'maxgolov/absl_variant_default' of http://github.com/ope… 

    …n-telemetry/opentelemetry-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed May 28, 2021
    Configuration menu
    Copy the full SHA
    719cc2d View commit details
    Browse the repository at this point in the history

  3. Code formatting change

    @maxgolov
    maxgolov committed May 28, 2021
    Configuration menu
    Copy the full SHA
    c478c17 View commit details
    Browse the repository at this point in the history

  4. Update .codecov.yaml 

    Make our codecov more forgiving
    @maxgolov
    maxgolov authored May 28, 2021
    Configuration menu
    Copy the full SHA
    ab2c5a9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'maxgolov/codecov_settings' of http://github.com/open-te… 

    …lemetry/opentelemetry-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed May 28, 2021
    Configuration menu
    Copy the full SHA
    8d37349 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Merge branch 'main' of http://github.com/open-telemetry/opentelemetry… 

    …-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    7303c95 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of http://github.com/open-telemetry/opentelemetry… 

    …-cpp into maxgolov/absl_variant_default
    @maxgolov
    maxgolov committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    d6f5d32 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Keep logs preview building

    @maxgolov
    maxgolov committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    ebdf934 View commit details
    Browse the repository at this point in the history

  2. Allow Resource Attributes initialized from common::AttributeValue

    @maxgolov
    maxgolov committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    692259c View commit details
    Browse the repository at this point in the history

  3. Apply code formatting

    @maxgolov
    maxgolov committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    553628b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into maxgolov/absl_variant_default

    @maxgolov
    maxgolov authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    752c525 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Update CMakeLists.txt 

    Turn preview features OFF
    @maxgolov
    maxgolov authored Jun 3, 2021
    Configuration menu
    Copy the full SHA
    26961fd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into maxgolov/absl_variant_default

    @maxgolov
    maxgolov authored Jun 3, 2021
    Configuration menu
    Copy the full SHA
    6d56e41 View commit details
    Browse the repository at this point in the history

  3. Remove unused template

    @maxgolov
    maxgolov committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    8646892 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Merge branch 'main' into maxgolov/absl_variant_default

    @maxgolov
    maxgolov authored Jun 4, 2021
    Configuration menu
    Copy the full SHA
    1cd471f View commit details
    Browse the repository at this point in the history