Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #804 #805

Merged
merged 2 commits into from
May 28, 2021
Merged

Fixes #804 #805

merged 2 commits into from
May 28, 2021

Conversation

owent
Copy link
Member

@owent owent commented May 27, 2021

Signed-off-by: owent admin@owent.net

Fixes #804

Changes

  1. Fix install rule for header files of ostream exporter
  2. Add more export targets for cmake

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

owent added 2 commits May 27, 2021 16:56
Signed-off-by: owent <admin@owent.net>
Signed-off-by: owent <admin@owent.net>
@owent owent requested a review from a team May 27, 2021 09:02
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #805 (e7ec34a) into main (ac0e617) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         176      176           
  Lines        7183     7183           
=======================================
  Hits         6896     6896           
  Misses        287      287           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Looks food.

@lalitb lalitb merged commit 2734b78 into open-telemetry:main May 28, 2021
@owent owent deleted the fix_cmake_porting branch May 28, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header files in ostream exporter are not installed when building with cmake.
3 participants