Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview feature-flag/macro for logs #807

Merged
merged 10 commits into from
May 29, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 28, 2021

Changes

Similar to #745, The otel-cpp logs implementation is in preview, so it needs to be behind the feature flag as we are planning for 1.0.0 RC ( 1.0.0 release is only for tracing signal, not metrics and logs).

  • As per the feature flag policy defined in Versioning.md - This PR wraps all the logs code (api, sdk, tests, exporter) under ENABLE_LOGS_PREVIEW hashdef.
#ifdef ENABLE_LOGS_PREVIEW
..
..
#endif 
  • Included cmake option WITH_LOGS_PREVIEW, default switched off. This is enabled during CI to ensure current log implementation doesn't break with any new changes.

The changes look huge as the clang-format does the indentation of preprocessor directives within this wrapper.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team May 28, 2021 11:09
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #807 (f36d751) into main (12e56f9) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   96.01%   96.19%   +0.18%     
==========================================
  Files         176      153      -23     
  Lines        7183     6444     -739     
==========================================
- Hits         6896     6198     -698     
+ Misses        287      246      -41     
Impacted Files Coverage Δ
api/include/opentelemetry/trace/noop.h 84.62% <0.00%> (-7.69%) ⬇️
...clude/opentelemetry/sdk/common/atomic_shared_ptr.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants