Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check size equalness before comparing the whole producer/consumer arrays #845

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

ThomsonTan
Copy link
Contributor

As tracked by #841, the failure in circular buffer test shows up periodically in the CI. Add one more test statement to log the size of producer/consumer arrays. The log of array comparison only shows a few elements at the beginning of the arrays. More test assertion will help us find the root cause.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team June 10, 2021 17:20
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #845 (daf5e89) into main (703a2a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   95.48%   95.48%   +0.01%     
==========================================
  Files         156      156              
  Lines        6614     6615       +1     
==========================================
+ Hits         6315     6316       +1     
  Misses        299      299              
Impacted Files Coverage Δ
sdk/test/common/circular_buffer_test.cc 100.00% <100.00%> (ø)

@lalitb lalitb merged commit 1f5b886 into open-telemetry:main Jun 11, 2021
@ThomsonTan ThomsonTan deleted the TestSizeOfCircularBuffer branch June 15, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants