-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reporting instrumentation library as jaeger span tags #863
reporting instrumentation library as jaeger span tags #863
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #863 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 156 156
Lines 6620 6620
=======================================
Hits 6322 6322
Misses 298 298 |
{} | ||
{ | ||
AddTag("otel.library.name", instrumentation_library.GetName()); | ||
AddTag("otel.library.version", instrumentation_library.GetVersion()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I am referring naming from here to validate : https://github.com/open-telemetry/opentelemetry-specification/blob/v1.4.0/specification/trace/sdk_exporters/non-otlp.md#instrumentationlibrary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing it. CLA is failing, so you would have to sign it.
I have already registered my company email id, but seems that this has been committed using my second id by mistake. Will I have to raise another PR with correct mail id to resolve this? |
yes I think you need to raise with correct id. |
sure, will do it. |
Closing the PR due to CLA issue, raised a new one #864 |
Fixes #768
Changes
Adding instrumentation library (name and version) in jaeger span as tags using thrift add tags.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes