Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporting instrumentation library as jaeger span tags #863

Closed

Conversation

anshulkumar19
Copy link
Contributor

Fixes #768

Changes

Adding instrumentation library (name and version) in jaeger span as tags using thrift add tags.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • [Y] Unit tests have been added
  • Changes in public API reviewed

@anshulkumar19 anshulkumar19 requested a review from a team June 16, 2021 15:52
@linux-foundation-easycla
Copy link

CLA Missing ID

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #863 (aadb2de) into main (b073e8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #863   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         156      156           
  Lines        6620     6620           
=======================================
  Hits         6322     6322           
  Misses        298      298           

{}
{
AddTag("otel.library.name", instrumentation_library.GetName());
AddTag("otel.library.version", instrumentation_library.GetVersion());
Copy link
Member

@lalitb lalitb Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing it. CLA is failing, so you would have to sign it.

@anshulkumar19
Copy link
Contributor Author

Thanks for contributing it. CLA is failing, so you would have to sign it.

I have already registered my company email id, but seems that this has been committed using my second id by mistake. Will I have to raise another PR with correct mail id to resolve this?

@lalitb
Copy link
Member

lalitb commented Jun 16, 2021

Thanks for contributing it. CLA is failing, so you would have to sign it.

I have already registered my company email id, but seems that this has been committed using my second id by mistake. Will I have to raise another PR with correct mail id to resolve this?

yes I think you need to raise with correct id.

@anshulkumar19
Copy link
Contributor Author

Thanks for contributing it. CLA is failing, so you would have to sign it.

I have already registered my company email id, but seems that this has been committed using my second id by mistake. Will I have to raise another PR with correct mail id to resolve this?

yes I think you need to raise with correct id.

sure, will do it.

@anshulkumar19
Copy link
Contributor Author

Closing the PR due to CLA issue, raised a new one #864

@anshulkumar19 anshulkumar19 deleted the bug/exporter_jaeger branch June 17, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger: Handle InstrumentationLibrary
3 participants