Rename bswap_64 to otel_bswap_64 to avoid clash with macro (#875) #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #876 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 157 157
Lines 6633 6633
=======================================
Hits 6330 6330
Misses 303 303 |
ThomsonTan
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875
Changes
On some platforms, bswap_64 is a macro. Rename the OpenTelemetry utility to otel_bswap_64 to avoid clashing with this.
For significant contributions please make sure you have completed the following items:
N/A
CHANGELOG.mdupdated for non-trivial changesN/A Unit tests have been added
Changes in public API reviewed
I believe this isn't part of the public API?