Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETW example and tests clean-up #882

Merged
merged 17 commits into from
Jul 1, 2021
Merged

ETW example and tests clean-up #882

merged 17 commits into from
Jul 1, 2021

Conversation

maxgolov
Copy link
Contributor

@maxgolov maxgolov commented Jun 29, 2021

Changes

Customer ask:

  • add example of a multi-threaded application. Illustrate best practices on passing context from main thread to workers.
  • added document that explains the flow and usage instructions how to debug the flow in Visual Studio using ETW exporter.

Clean-up:

  • fix typo
  • do not pass 2nd argument in ETW tests. It is misleading (should be version), and unused by ETW header-only tracer anyways.

Additional tests:

  • illustrate how to create global tracer provider using magic statics.
  • obtain different tracers, verify that they get different trace id.
  • verify that the same global tracer returns the same trace id.

Also I added some comments showing event payload contents in ETW tests.
This comes in handy to better understand how provider works.

No changes to public API.

@maxgolov maxgolov requested a review from a team June 29, 2021 22:26
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #882 (b880e30) into main (b5dd914) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         157      157           
  Lines        6633     6633           
=======================================
  Hits         6330     6330           
  Misses        303      303           
Impacted Files Coverage Δ
...pi/include/opentelemetry/context/runtime_context.h 97.47% <ø> (ø)

@maxgolov maxgolov added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jun 30, 2021
@lalitb lalitb merged commit 47859cc into main Jul 1, 2021
@lalitb lalitb deleted the maxgolov/etw_example_cleanup branch July 1, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants