Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add bazel build for grpc example #910

Merged
merged 3 commits into from
Jul 20, 2021
Merged

✨ add bazel build for grpc example #910

merged 3 commits into from
Jul 20, 2021

Conversation

esigo
Copy link
Member

@esigo esigo commented Jul 18, 2021 •
edited
Loading

Fixes # (issue)
#838 (comment)

Changes

Add bazel build support to build gRPC example.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Jul 18, 2021 •
edited
Loading

Codecov Report

Merging #910 (b4aed22) into main (ecb9a27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         158      158           
  Lines        6749     6749           
=======================================
  Hits         6441     6441           
  Misses        308      308

@esigo esigo marked this pull request as ready for review July 18, 2021 17:54
@esigo esigo requested a review from a team July 18, 2021 17:54
lalitb
lalitb approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the bazel support.

@esigo
Copy link
Member Author

esigo commented Jul 19, 2021

Thank you for adding the bazel support.

Thanks for the review. Glad to contribute :)

@lalitb lalitb merged commit 40d2eb5 into open-telemetry:main Jul 20, 2021
@esigo esigo deleted the esigo/Add-bazel-build-for-grpc-example branch July 22, 2021 15:29
@lalitb lalitb mentioned this pull request Nov 11, 2021
Closed
@esigo esigo mentioned this pull request Nov 23, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esigo @ThomsonTan @lalitb