Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel build for Zipkin #916

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Bazel build for Zipkin #916

merged 3 commits into from
Jul 21, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 21, 2021

Changes

Bazel build for zipkin. Also removed some code warnings during bazel build.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team July 21, 2021 09:49
@lalitb lalitb changed the title Bazel build for zupkin Bazel build for Zipkin Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #916 (00894d0) into main (2037fa7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         158      158           
  Lines        6749     6749           
=======================================
  Hits         6441     6441           
  Misses        308      308           

@lalitb lalitb mentioned this pull request Jul 21, 2021
3 tasks
@lalitb lalitb merged commit 2b3fe84 into open-telemetry:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants