Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casting to microseconds #937

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Fix casting to microseconds #937

merged 2 commits into from
Aug 3, 2021

Conversation

srgbtl
Copy link
Contributor

@srgbtl srgbtl commented Aug 3, 2021

Changes

std::chrono::duration can be converted to integral value via count() function

@srgbtl srgbtl requested a review from a team August 3, 2021 14:03
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 3, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #937 (dedb8d3) into main (fa107a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         160      160           
  Lines        6780     6780           
=======================================
  Hits         6465     6465           
  Misses        315      315           
Impacted Files Coverage Δ
api/include/opentelemetry/trace/tracer.h 100.00% <ø> (ø)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@ThomsonTan ThomsonTan merged commit dc25ea6 into open-telemetry:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants