Update default OTLP http port #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Aug 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 160 160
Lines 6780 6780
=======================================
Hits 6465 6465
Misses 315 315 |
|
@ThomsonTan please follow up on open-telemetry/opentelemetry-specification#1847. @lalitb FYI. |
ThomsonTan
added a commit
to ThomsonTan/opentelemetry-cpp
that referenced
this pull request
Aug 5, 2021
This reverts commit 05444a8.
lalitb
pushed a commit
that referenced
this pull request
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The default OTLP over HTTP port was changed from
4317to4318. Update our exporter to comply with the spec.open-telemetry/opentelemetry-specification#1839
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes