Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update default OTLP http port (#939)" #941

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Revert "Update default OTLP http port (#939)" #941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5df066c
Revert "Update default OTLP http port (#939)"
ThomsonTan Aug 5, 2021
3e93572
Merge branch 'main' into RevertOtlpHttp
ThomsonTan Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions exporters/otlp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ auto exporter = std::unique_ptr<sdktrace::SpanExporter>(new otlp::OtlpHttpExport

### Configuration options

| Option | Default |
| ------------------------------------ |----------------- |
| `OtlpGrpcExporterOptions.endpoint` | `localhost:4317` |
| `OtlpHttpExporterOptions.endpoint` | `localhost:4318` |
| Option | Default |
| ------------ |----------------- |
| `endpoint` | `localhost:4317` |

## Example

Expand Down
2 changes: 1 addition & 1 deletion exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_exporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ struct OtlpHttpExporterOptions
// @see
// https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md
// @see https://github.com/open-telemetry/opentelemetry-collector/tree/main/receiver/otlpreceiver
std::string url = std::string("http://localhost:4318") + kDefaultTracePath;
std::string url = std::string("http://localhost:4317") + kDefaultTracePath;

// By default, post json data
HttpRequestContentType content_type = HttpRequestContentType::kJson;
Expand Down