Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not set parentId in case parentId is empty #943

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Not set parentId in case parentId is empty #943

merged 2 commits into from
Aug 11, 2021

Conversation

andriy-fd
Copy link
Contributor

Fixes # (issue)
The root Span is not displayed in SignalFX (Splunk APM) when data is exported via Zipkin exporter.
According to https://zipkin.io/zipkin-api/#/ (ListOfSpans seection) the parentId element should be absent for root span

Changes

added logic into Zipkin's recordable implementation to add parentId element only when parentId is valid.

@andriy-fd andriy-fd requested a review from a team August 10, 2021 08:08
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 10, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix. You would have to authorize easyCLA before it can be merged.

Also to format code before commit, run below from root directory:
$ ./ci/do_ci.sh format

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #943 (2638700) into main (f4ff74c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         160      160           
  Lines        6780     6780           
=======================================
  Hits         6465     6465           
  Misses        315      315           

@lalitb lalitb merged commit 4120258 into open-telemetry:main Aug 11, 2021
@lalitb lalitb mentioned this pull request Sep 17, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants