Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate baggage<->Context api from Baggage Propagator #963

Merged
merged 6 commits into from
Aug 30, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Aug 26, 2021

Fixes #961

Changes

As mentioned in #961, getter/setter methods for baggage on Context shouldn't be part of Baggage Propagator.

Moved

  • opentelemetry::baggage::propagation::GetBaggage() to opentelemetry::baggage::GetBaggage()
  • opentelemetry::baggage::propagation::SetBaggage() to opentelemetry::baggage::GetBaggage()
  • opentelemetry::baggage::propagation::kBaggageHeader to opentelemetry::baggage::kBaggageHeader

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team August 26, 2021 23:10
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #963 (19600ca) into main (4ae969b) will not change coverage.
The diff coverage is 90.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #963   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         160      161    +1     
  Lines        6780     6780           
=======================================
  Hits         6465     6465           
  Misses        315      315           
Impacted Files Coverage Δ
...pi/include/opentelemetry/baggage/baggage_context.h 75.00% <75.00%> (ø)
...telemetry/baggage/propagation/baggage_propagator.h 100.00% <100.00%> (+11.77%) ⬆️
...est/baggage/propagation/baggage_propagator_test.cc 100.00% <100.00%> (ø)

@lalitb lalitb merged commit 7b1842b into open-telemetry:main Aug 30, 2021
@lalitb lalitb mentioned this pull request Sep 17, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baggage <-> Context interaction on Baggage as static methods?
2 participants