Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup GetEnvironmentVariable and remove unused variable under NO_GETENV #976

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

ThomsonTan
Copy link
Contributor

Changes

When NO_GETENV is used, it is unnecessary to define a pointer to save the result as it is always nullptr.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team September 9, 2021 22:40
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #976 (1b0cb55) into main (fc8f854) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #976   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         161      161           
  Lines        6817     6817           
=======================================
  Hits         6502     6502           
  Misses        315      315           
Impacted Files Coverage Δ
...k/include/opentelemetry/sdk/common/env_variables.h 100.00% <100.00%> (ø)

@lalitb lalitb merged commit c8b35ff into open-telemetry:main Sep 9, 2021
@lalitb lalitb mentioned this pull request Sep 17, 2021
3 tasks
@ThomsonTan ThomsonTan deleted the CleanGetEnv branch September 22, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants