Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema_url support to both Resource and InstrumentationLibrary #979

Merged
merged 7 commits into from
Sep 21, 2021

Conversation

ThomsonTan
Copy link
Contributor

Fixes #948

Changes

Add schema_url as an optional parameter to both API and SDK.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team September 16, 2021 19:00
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #979 (8578ab8) into main (0500d6d) will increase coverage by 0.03%.
The diff coverage is 96.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   95.38%   95.41%   +0.03%     
==========================================
  Files         161      161              
  Lines        6817     6833      +16     
==========================================
+ Hits         6502     6519      +17     
+ Misses        315      314       -1     
Impacted Files Coverage Δ
api/include/opentelemetry/trace/noop.h 86.21% <0.00%> (ø)
api/include/opentelemetry/trace/tracer_provider.h 100.00% <ø> (ø)
api/test/trace/provider_test.cc 80.00% <ø> (ø)
sdk/include/opentelemetry/sdk/resource/resource.h 100.00% <ø> (ø)
...k/instrumentationlibrary/instrumentation_library.h 100.00% <100.00%> (ø)
sdk/src/resource/resource.cc 96.67% <100.00%> (+4.67%) ⬆️
sdk/src/trace/tracer_provider.cc 74.36% <100.00%> (+0.68%) ⬆️
sdk/test/resource/resource_test.cc 93.86% <100.00%> (+0.41%) ⬆️
sdk/test/trace/tracer_provider_test.cc 100.00% <100.00%> (ø)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the support :)

@ThomsonTan ThomsonTan merged commit 5de793d into open-telemetry:main Sep 21, 2021
@ThomsonTan ThomsonTan deleted the add_schema_url branch September 21, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add schema_url to TracerProvider.get
2 participants