Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cross compling grpc_cpp_plugin not found bug #982

Merged
merged 6 commits into from
Sep 22, 2021
Merged

cross compling grpc_cpp_plugin not found bug #982

merged 6 commits into from
Sep 22, 2021

Conversation

seanchann
Copy link
Contributor

Fixes # (issue)

Changes

  • need use find_program on host when CMAKE_CROSSCOMPILING enable

@seanchann seanchann requested a review from a team September 18, 2021 09:54
@seanchann seanchann changed the title Update opentelemetry-proto.cmake cross compling grpc_cpp_plugin not found bug Sep 18, 2021
@codecov
Copy link

codecov bot commented Sep 20, 2021 •
edited
Loading

Codecov Report

Merging #982 (ad21564) into main (5ae482c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files         161      161           
  Lines        6833     6833           
=======================================
  Hits         6519     6519           
  Misses        314      314

@ThomsonTan ThomsonTan merged commit 93b3105 into open-telemetry:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
build and test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanchann @ThomsonTan @lalitb